Skip to content
This repository has been archived by the owner. It is now read-only.
Permalink
Browse files
fix UB
  • Loading branch information
aap committed Dec 31, 2020
1 parent 77884e0 commit 1a8a1c91cb30d592e8f46c9b45f663e2ad82ed5c
Showing with 5 additions and 0 deletions.
  1. +5 −0 src/weapons/Explosion.cpp
@@ -104,7 +104,12 @@ CExplosion::AddExplosion(CEntity *explodingEntity, CEntity *culprit, eExplosionT
#endif #endif


int n = 0; int n = 0;
#ifdef FIX_BUGS
while (n < ARRAY_SIZE(gaExplosion) && gaExplosion[n].m_nIteration != 0)
#else
// array overrun is UB
while (gaExplosion[n].m_nIteration != 0 && n < ARRAY_SIZE(gaExplosion)) while (gaExplosion[n].m_nIteration != 0 && n < ARRAY_SIZE(gaExplosion))
#endif
n++; n++;
if (n == ARRAY_SIZE(gaExplosion)) if (n == ARRAY_SIZE(gaExplosion))
return false; return false;

0 comments on commit 1a8a1c9

Please sign in to comment.