Skip to content
This repository has been archived by the owner. It is now read-only.

Water droplet effect stops working, when looking away in vehicles #906

Closed
ttyborg opened this issue Dec 28, 2020 · 5 comments
Closed

Water droplet effect stops working, when looking away in vehicles #906

ttyborg opened this issue Dec 28, 2020 · 5 comments
Labels

Comments

@ttyborg
Copy link

@ttyborg ttyborg commented Dec 28, 2020

Water droplet effect stops working, when looking to the sides or behind, in vehicles.

Droplets stop in place and slowly disappear, then no additional droplet appears on the screen, until releasing the "look left/right/behind" buttons.

On foot it works, however, the trailing effect of the droplets stops working, when running towards the camera.

Both in re3 and reVC.

@aap
Copy link
Member

@aap aap commented Dec 28, 2020

this should be original behaviour. in the code we have this:

	ms_enabled = !isTopDown && !isLookingInDirection;
	ms_movingEnabled = !isTopDown && !isLookingInDirection;

@ttyborg
Copy link
Author

@ttyborg ttyborg commented Dec 28, 2020

Ah, okay. I thought there was something wrong, because in the originals (at least in VC) it worked no matter if looked to the sides or behind.

@aap
Copy link
Member

@aap aap commented Dec 28, 2020

hm, i took the code mostly from III. can you check that maybe?

@ThirteenAG
Copy link
Member

@ThirteenAG ThirteenAG commented Dec 28, 2020

It should work, there's an error.
https://www.youtube.com/watch?v=VTEJdDJmq4w&hd=1

@aap
Copy link
Member

@aap aap commented Dec 28, 2020

fixed. was missing condition

@aap aap closed this Dec 28, 2020
@ghost ghost added the bug label Jan 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants