Skip to content
This repository has been archived by the owner. It is now read-only.

fix: printHash.sh; replace echo -n, check if $1 is set. #1188

Merged
merged 1 commit into from Jul 5, 2021
Merged

fix: printHash.sh; replace echo -n, check if $1 is set. #1188

merged 1 commit into from Jul 5, 2021

Conversation

@mssx86
Copy link
Contributor

@mssx86 mssx86 commented Jul 1, 2021

this pull request rewrites printHash.sh to get rid of the dependency on bash and bashisms (the use of echo -n) for hosts without bash. it also does a simple check to see if $1 is set and removes the unnecessary >$1 as the first invocation of printf already does that.

checked with bash 5.1.8, yash 2.51 and busybox ash 1.33.1.

@erorcun erorcun merged commit 164623d into GTAmodding:master Jul 5, 2021
22 checks passed
22 checks passed
@github-actions
build-cmake (windows-latest, gl3, glfw, openal)
Details
@github-actions
build (win-amd64-librw_d3d9-oal, Debug)
Details
@github-actions
build (win-x86-librw_d3d9-mss, Debug)
Details
@github-actions
build-cmake (windows-latest, d3d9, openal)
Details
@github-actions
build (win-amd64-librw_d3d9-oal, Release)
Details
@github-actions
build (win-x86-librw_d3d9-mss, Release)
Details
@github-actions
build-cmake (ubuntu-18.04, gl3, glfw, openal)
Details
@github-actions
build (win-amd64-librw_d3d9-oal, Vanilla)
Details
@github-actions
build (win-x86-librw_d3d9-mss, Vanilla)
Details
@github-actions
build-cmake (macos-latest, gl3, glfw, openal)
Details
@github-actions
build (win-amd64-librw_gl3_glfw-oal, Debug)
Details
@github-actions
build (win-x86-librw_gl3_glfw-mss, Debug)
Details
@github-actions
build (win-amd64-librw_gl3_glfw-oal, Release)
Details
@github-actions
build (win-x86-librw_gl3_glfw-mss, Release)
Details
@github-actions
build (win-amd64-librw_gl3_glfw-oal, Vanilla)
Details
@github-actions
build (win-x86-librw_gl3_glfw-mss, Vanilla)
Details
@github-actions
build (win-x86-librw_d3d9-oal, Debug)
Details
@github-actions
build (win-x86-librw_d3d9-oal, Release)
Details
@github-actions
build (win-x86-librw_d3d9-oal, Vanilla)
Details
@github-actions
build (win-x86-librw_gl3_glfw-oal, Debug)
Details
@github-actions
build (win-x86-librw_gl3_glfw-oal, Release)
Details
@github-actions
build (win-x86-librw_gl3_glfw-oal, Vanilla)
Details
@withmorten
Copy link
Contributor

@withmorten withmorten commented Jul 5, 2021

cherry-picked them both over to miami!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants