This repository has been archived by the owner. It is now read-only.
ProjectileInfo #290
Merged
ProjectileInfo #290
Conversation
|
small nitpicks |
| matrix.GetForward() = TheCamera.Cams[TheCamera.ActiveCam].Front; | ||
| matrix.GetUp() = TheCamera.Cams[TheCamera.ActiveCam].Up; | ||
| matrix.GetRight() = CrossProduct(TheCamera.Cams[TheCamera.ActiveCam].Up, TheCamera.Cams[TheCamera.ActiveCam].Front); | ||
| matrix.GetPosition() = pos; |
ghost
Jan 12, 2020
nit: here I thought about adding setter SetPosition and using later?
nit: here I thought about adding setter SetPosition and using later?
| { | ||
| case WEAPONTYPE_ROCKETLAUNCHER: | ||
| { | ||
| float vy = 1.25f; |
ghost
Jan 12, 2020
maybe variables named vX, ,vY, vZ? @aap
maybe variables named vX, ,vY, vZ? @aap
| velocity.x = -1.0f * scale * Sin(angle); | ||
| velocity.y = scale * Cos(angle); | ||
| velocity.z = (0.4f * speed + 0.4f) * scale; |
Comment on lines
+113
to
+115
ghost
Jan 12, 2020
unoptimized operator?
unoptimized operator?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
No description provided.