This repository has been archived by the owner. It is now read-only.
garages #372
Merged
garages #372
Conversation
src/control/Garages.cpp
Outdated
| if (FindPlayerPed()->m_objective == OBJECTIVE_LEAVE_VEHICLE) | ||
| return false; | ||
| CVehicle* pVehicle = FindPlayerVehicle(); | ||
| if (pVehicle->GetPosition().x < m_fX1) |
aap
Mar 31, 2020
Member
maybe put x,y,z together with || ?. also in all the other places
maybe put x,y,z together with || ?. also in all the other places
src/control/Garages.h
Outdated
| @@ -181,7 +182,7 @@ class CGarages | |||
| static int32 &CrushedCarId; | |||
| static uint32 &LastTimeHelpMessage; | |||
| static int32 &MessageNumberInString; | |||
| static const char *MessageIDString; | |||
| static char(&MessageIDString)[8]; | |||
ghost
Mar 31, 2020
define or enum in config.h?
define or enum in config.h?
|
+1 for aap's suggestion |
| return; | ||
| float posX = pVehicle->GetPosition().x; | ||
| float posY = pVehicle->GetPosition().y; | ||
| float posZ = pVehicle->GetPosition().z; |
erorcun
Mar 31, 2020
Collaborator
wouldn't CVector better in here
wouldn't CVector better in here
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
No description provided.