This repository has been archived by the owner. It is now read-only.
Record #402
Merged
Record #402
+612
−31
Conversation
src/control/Record.cpp
Outdated
| pState->rightX = UINT8_MAX / 2 * pCar->GetRight().x; | ||
| pState->rightY = UINT8_MAX / 2 * pCar->GetRight().y; | ||
| pState->rightZ = UINT8_MAX / 2 * pCar->GetRight().z; | ||
| pState->forwardX = UINT8_MAX / 2 * pCar->GetForward().x; | ||
| pState->forwardY = UINT8_MAX / 2 * pCar->GetForward().y; | ||
| pState->forwardZ = UINT8_MAX / 2 * pCar->GetForward().z; | ||
| pState->pos = pCar->GetPosition(); | ||
| pState->velX = 1.0f * (UINT16_MAX / 2) * pCar->GetMoveSpeed().x; | ||
| pState->velY = 1.0f * (UINT16_MAX / 2) * pCar->GetMoveSpeed().y; | ||
| pState->velZ = 1.0f * (UINT16_MAX / 2) * pCar->GetMoveSpeed().z; |
Comment on lines
333
to
342
ghost
Apr 10, 2020
maybe pState should use more CVector?
maybe pState should use more CVector?
Nick007J
Apr 10, 2020
Author
Contributor
these are 1 byte variables
these are 1 byte variables
| pState->velX = 0.5f * INT16_MAX * pCar->GetMoveSpeed().x; | ||
| pState->velY = 0.5f * INT16_MAX * pCar->GetMoveSpeed().y; | ||
| pState->velZ = 0.5f * INT16_MAX * pCar->GetMoveSpeed().z; |
Comment on lines
+340
to
+342
ghost
Apr 10, 2020
shouldn't 0.5f be removed?
shouldn't 0.5f be removed?
Nick007J
Apr 11, 2020
Author
Contributor
it was a mistake in original PR
it was a mistake in original PR
|
lgtm |
src/control/Record.cpp
Outdated
| RecordingState = STATE_PLAYBACK; | ||
| } | ||
| if (RecordingState == STATE_PLAYBACK) { | ||
| pDataBufferPointer = (uint8*)malloc(MEMORY_FOR_GAME_RECORD); |
aap
Apr 11, 2020
Member
new
new
|
lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
No description provided.