This repository has been archived by the owner. It is now read-only.
Fixing an original issue: removing unneeded white color codes #907
+941
−938
Conversation
…itles This is an original issue. It seems that certain cutscenes had a white color control code in their subtitles when - It's not needed for subtitles. - The ~w~ control code isn't pure white, but light gray, so those subtitles look different than the rest. I've also fixed a couple of unwanted spaces found in French and German, and also tweaked one string in Spanish and added the translation for the new Waypoint string.
|
Changes unwelcomed by the core team. |
Out of curiosity, why aren't these changes welcome? |
|
The team considered those |
|
Superseded by #923. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This is an original issue. It seems that certain cutscenes had a white color control code in their subtitles when
~w~control code isn't pure white, but light gray, so those subtitles look different than the rest.I've also fixed a couple of unwanted spaces found in French and German, and also tweaked one string in Spanish and added the translation for the new Waypoint string.
The text was updated successfully, but these errors were encountered: