Skip to content
This repository has been archived by the owner. It is now read-only.

Sprite Scaling Option #909

Merged
merged 13 commits into from Jan 8, 2021
Merged

Sprite Scaling Option #909

merged 13 commits into from Jan 8, 2021

Conversation

@Fire-Head
Copy link
Member

@Fire-Head Fire-Head commented Dec 29, 2020

No description provided.

src/render/Draw.h Outdated Show resolved Hide resolved
utils/gxt/american.txt Show resolved Hide resolved
@erorcun
Copy link
Collaborator

@erorcun erorcun commented Jan 1, 2021

can you merge Hud Scaling and PS2_HUD options? I mean having 2 options are confusing, and PC scaling + PS2_HUD is not PS2 hud, am I wrong?

@Fire-Head
Copy link
Member Author

@Fire-Head Fire-Head commented Jan 1, 2021

i would like to have PS2 scaling(+radar/coronas fix) for PC hud too, since this is the only correct combination, but not everyone likes it so for that case i made an option in frontend.

I can offer only two solutions:

  1. leave the option as is and rename it to "SCALING" to make a bit less confusing.
  2. remove the option but enable PS2 scaling by default(with proper radar/coronas).

@erorcun
Copy link
Collaborator

@erorcun erorcun commented Jan 1, 2021

what about 2nd option + combining PS2 scaling and PS2 hud coordinates into one define, and making proper radar/coronas into seperate define?

edit: I changed my mind, PS2 scaling define + PS2 hud define + seperate proper radar/coronas define all without any frontend options, but PS2 scaling is enabled by default, is that ok?

@Fire-Head
Copy link
Member Author

@Fire-Head Fire-Head commented Jan 1, 2021

what about 2nd option + combining PS2 scaling and PS2 hud coordinates into one define, and making proper radar/coronas into seperate define?

PC hud scaling in such case will remain broken and proper radar/coronas will be impossible without PS2_HUD.

edit: I changed my mind, PS2 scaling define + PS2 hud define + seperate proper radar/coronas define all without any frontend options, but PS2 scaling is enabled by default, is that ok?

If new defines are enabled by default(except PS2_HUD) and no one minds then ok.

@ghost
ghost approved these changes Jan 6, 2021
Copy link

@ghost ghost left a comment

lgtm

@Fire-Head Fire-Head merged commit 6e42c79 into GTAmodding:master Jan 8, 2021
12 of 13 checks passed
12 of 13 checks passed
@github-actions
build (win-amd64-librw_d3d9-oal, Debug)
Details
@github-actions
build (win-x86-librw_d3d9-mss, Debug)
Details
@github-actions
build (win-amd64-librw_d3d9-oal, Release)
Details
@github-actions
build (win-x86-librw_d3d9-mss, Release)
Details
@github-actions
build (win-amd64-librw_gl3_glfw-oal, Debug)
Details
@github-actions
build (win-x86-librw_gl3_glfw-mss, Debug)
Details
@github-actions
build (win-amd64-librw_gl3_glfw-oal, Release)
Details
@github-actions
build (win-x86-librw_gl3_glfw-mss, Release)
Details
@github-actions
build (win-x86-librw_d3d9-oal, Debug)
Details
@github-actions
build (win-x86-librw_d3d9-oal, Release)
Details
@github-actions
build (win-x86-librw_gl3_glfw-oal, Debug)
Details
@github-actions
build (win-x86-librw_gl3_glfw-oal, Release)
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants