Added the functionality to specify the StartupWMClass in mLauncher#2
Open
Manuel-Kehl wants to merge 2 commits intoGabMus:masterfrom
Open
Added the functionality to specify the StartupWMClass in mLauncher#2Manuel-Kehl wants to merge 2 commits intoGabMus:masterfrom
Manuel-Kehl wants to merge 2 commits intoGabMus:masterfrom
Conversation
added 2 commits
October 24, 2015 13:25
I added a label and a text entry with corresponding tool tip.
I added the corresponding lines to the loading and saving functions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I mostly use mLauncher to create "Chromium webapps", i.e.
chromium --app="URL"as executable.While assigning icons to the .desktop file works for launching the app, it does not work at runtime, as it returns to the default Chromium icon. To fix that, the URL (without
http[s]://) has to be added asStartupWMClass, which is now possible via mLauncher 😉💡 For the future one could even think about creating a single button "create Chrome/Chromium webapp" with a popup that handles URL processing, so that the user simply specifies the URL, name and icon. What do you think about that?