CollectScenes : Replace bogus ArrayPlug input with ScenePlug #2726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We appear to have got away with this egregious mistake due to a compatibility config allowing us to perform the expected `collectScenes["in"].setInput( otherNode["out"] )`. The fix is a single line in CollectScenes.cpp, but requires another compatibility config to allow us to load old scripts, which have serialisations referring to children of the old ArrayPlug.
|
Putting this on hold temporarily - it should go into 0.49 rather than 0.48.x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We appear to have got away with this egregious mistake due to a compatibility config allowing us to perform the expected
collectScenes["in"].setInput( otherNode["out"] ). The fix is a single line in CollectScenes.cpp, but requires another compatibility config to allow us to load old scripts, which have serialisations referring to children of the old ArrayPlug.