Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support automatic variable substitution during ExecutableNode::execute() #887

Closed
johnhaddon opened this issue Jun 30, 2014 · 0 comments
Assignees
Labels
Milestone

Comments

@johnhaddon
Copy link
Member

@johnhaddon johnhaddon commented Jun 30, 2014

We currently automatically substitute variables in StringPlug::getValue() when inside ComputeNode::compute(). We need to do the same during ExecutableNode::execute().

@johnhaddon johnhaddon added this to the Dispatching milestone Jun 30, 2014
johnhaddon added a commit to johnhaddon/gaffer that referenced this issue May 11, 2015
It was always awkward that this was defined on the base class but only made any sense on the derived StringPlug class. Furthermore it now provides only very crude control compared to the new StringPlug constructor argument.

Replaced all uses of the flag with the new method, except GafferCortex::TypedParameterHandler - this will require a slightly more complex change (adding a FileSequenceParameterHandler) and will be best addressed when we also address automatic variable substitution for ExecutableNodes (GafferHQ#887). In the meantime, it provides test coverage for the operation of the deprecated feature.
johnhaddon added a commit to johnhaddon/gaffer that referenced this issue May 11, 2015
It was always awkward that this was defined on the base class but only made any sense on the derived StringPlug class. Furthermore it now provides only very crude control compared to the new StringPlug constructor argument.

Replaced all uses of the flag with the new method, except GafferCortex::TypedParameterHandler - this will require a slightly more complex change (adding a FileSequenceParameterHandler) and will be best addressed when we also address automatic variable substitution for ExecutableNodes (GafferHQ#887). In the meantime, it provides test coverage for the operation of the deprecated feature.
johnhaddon referenced this issue in andrewkaufman/gaffer Jul 13, 2015
I've left this as a separate commit, because I wasn't sure of the impact... all test cases pass still, so hopefully it's alright. Without this change, GafferImageTest.ImageWriterTest.testDefaultFormatWrite fails, complaining that it's trying to write an empty display window.

Fixes GafferHQ#1250
johnhaddon referenced this issue in HughMacdonald/gaffer Oct 22, 2015
johnhaddon added a commit to johnhaddon/gaffer that referenced this issue Mar 10, 2016
This makes it possible to monitor using a custom Monitor subclass. It also means that string plugs are automatically substituted during execution, relieving ExecutableNode implementations of the responsibility of doing that manually, and fixing numerous bugs where they weren't.

Fixes GafferHQ#887.
johnhaddon added a commit to johnhaddon/gaffer that referenced this issue Jun 12, 2016
johnhaddon added a commit to johnhaddon/gaffer that referenced this issue Jun 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.