Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FormatData : Make hash stable with GCC 4.4.7. #1669

Merged
merged 1 commit into from Mar 9, 2016

Conversation

@johnhaddon
Copy link
Member

johnhaddon commented Mar 9, 2016

This one is a bit beyond my understanding. While working with the new PerformanceMonitor I noticed that an expression was being hashed more often than it should have been, and traced it down to the hash for the "image:defaultFormat" context variable changing each time it was computed.

This only occurred with GCC 4.4.7 - the new unit test already passed with GCC 4.8.3 and 4.6.3 and 5, and Clang 3.4. I got as far as verifying that the assembly for SimpleDataHolder<GafferImage::Format>::hash() was different in GCC 4.4.7, but at that point things were beyond me. The simple change to referencing rather than copying the Format object fixes things, and at this point I'm afraid to say that's good enough for me.

This one is a bit beyond my understanding. While working with the new PerformanceMonitor I noticed that an expression was being hashed more often than it should have been, and traced it down to the hash for the "image:defaultFormat" context variable changing each time it was computed.

This only occurred with GCC 4.4.7 - the new unit test already passed with GCC 4.8.3 and 4.6.3 and 5, and Clang 3.4. I got as far as verifying that the assembly for `SimpleDataHolder<GafferImage::Format>::hash()` was different in GCC 4.4.7, but at that point things were beyond me. The simple change to referencing rather than copying the Format object fixes things, and at this point I'm afraid to say that's good enough for me.
andrewkaufman added a commit that referenced this pull request Mar 9, 2016
FormatData : Make hash stable with GCC 4.4.7.
@andrewkaufman andrewkaufman merged commit 266737b into GafferHQ:master Mar 9, 2016
2 checks passed
2 checks passed
codacy/pr Good work! The project quality is stable.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@johnhaddon johnhaddon deleted the johnhaddon:formatHash branch Mar 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.