Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gaffer.Metadata : Leaking metadata signals #2097

Merged
merged 2 commits into from May 25, 2017

Conversation

@ivanimanishi
Copy link
Member

ivanimanishi commented May 23, 2017

"Leaking" Metadata signals so that python doesn't crash during shutdown.

Here is @johnhaddon 's explanation for the cause of the crashes:

I think the issue here is that the nodeValueChangedSignal is static, and so gets deleted automatically during shutdown. When it is deleted, all the connected slots are deleted too, and in this case there is a python object connected as a slot. So we end up trying to delete a python object after/during python shutdown and python doesn't seem to like that. Python's shutdown process is a bit rubbish really, so I think we'll need to work around this on the Gaffer side.

I think the easiest approach might be to "leak" the signals so they don't get deleted during shutdown.

When using Metadata signals, python is crashing during shutdown.
This way, they don't get deleted during python shutdown.
@ivanimanishi

This comment has been minimized.

Copy link
Member Author

ivanimanishi commented May 24, 2017

Is there anything I need to do about the failed check?
Seems to be some type of time-out during compilation on one of the variations.

@johnhaddon

This comment has been minimized.

Copy link
Member

johnhaddon commented May 24, 2017

I've restarted the Travis test for that platform - looks like it errored while trying to download the dependencies. It's been happening a lot on the Macs lately - nothing to do with your PR...

@johnhaddon johnhaddon merged commit 74b2bd1 into GafferHQ:master May 25, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@johnhaddon

This comment has been minimized.

Copy link
Member

johnhaddon commented May 25, 2017

Thanks Ivan!

@ivanimanishi ivanimanishi deleted the ivanimanishi:leakingMetadataSignals branch May 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.