Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout Improvements #2522

Merged

Conversation

Projects
None yet
2 participants
@johnhaddon
Copy link
Member

commented Mar 29, 2018

This removes the widely hated auto-maximise of panels and replaces it with a much simpler mechanism. It also fixes a longstanding circular reference bug in the panel menus, and does some refactoring that puts us in a better place to implement future layout improvements (floating editors, drag and drop etc).

Marking as pr-majorVersion because of 34e689c, but it would be totally possible to merge without that commit if you want to get it into a patch version.

johnhaddon added some commits Mar 29, 2018

CompoundEditor : Simplify space-bar panel expansion
Nobody liked the existing approach, especially the "auto expand on enter" behaviour.
SplitContainer : Remove animation
Breaking Changes :

- SplitContainer :
	- Removed `animationDuration` argument from `setSizes()` method
	- Removed `targtSizes()` method
CompoundEditor : Remove garbage collection hack
As documented in the todo, this only masks circular reference bugs in the rest of the UI.
CompoundEditor : Refactor functionality into component classes
This achieves two things :

- Improves clarity
- Removes circular references from the panel menus. These could cause errors and even crashes during shutdown
@johnhaddon

This comment has been minimized.

Copy link
Member Author

commented Apr 10, 2018

Just noting quickly that I think we can close #1206 once this is merged.

@andrewkaufman andrewkaufman merged commit 7d3d6e3 into GafferHQ:master May 1, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@johnhaddon johnhaddon deleted the johnhaddon:compoundEditorImprovements branch May 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.