SceneViewUI LookThrough menu : Defer camera and light set computation until required #2567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large production scenes can have expensive set computations, and several uses of the LookThrough tool menu don't require that expense. Note this also makes the LookThrough tool more permissive, in that it accepts drop events from objects that can't be "looked through". Fortunately the Viewer play along and presents the error in a clear manner.
|
I've removed the unnecessary loop, and squash rebased ontop of master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Large production scenes can have expensive set computations, and several uses of the LookThrough tool menu don't require that expense. Hopefully the first commit is non-contentious. The 2nd commit is more-so, but I'd argue the excessively permissive drag/drop is worth the computation savings, especially now that we have a visual indication in the viewer itself:
https://github.com/GafferHQ/gaffer/blob/16a970c425bc5c01ef25381215638900a37c020a/sphereCam.png