Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PythonCommand improvements #3029

Merged
merged 2 commits into from Feb 19, 2019
Merged

Conversation

@johnhaddon
Copy link
Member

johnhaddon commented Feb 19, 2019

This fixes the bug described in #3027, and for good measure adds some worthwhile optimisations that I've had lying around for a little while.

johnhaddon added 2 commits Feb 19, 2019
It turns out that parsing and compilation are really slow. I don't have performance numbers from a production setup, but in some trivial-but-not-implausible test scenarios I'm seeing speedups ranging from 20% or so, right up to 7x.
@johnhaddon johnhaddon requested a review from danieldresser-ie Feb 19, 2019
@danieldresser-ie

This comment has been minimized.

Copy link
Contributor

danieldresser-ie commented Feb 19, 2019

LGTM

@johnhaddon johnhaddon merged commit 39df5b1 into GafferHQ:master Feb 19, 2019
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
@johnhaddon johnhaddon deleted the johnhaddon:pythonCommandCrashFix branch Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.