Gagravarr

  • Joined on
@Gagravarr
@Gagravarr
@Gagravarr
@Gagravarr
  • @Gagravarr da0f7c8
    Tweak markdown for github
@Gagravarr
Gagravarr commented on pull request apache/tika#51
@Gagravarr

Would you be able to re-do this without the whitespace changes? And ideally also with a small sample file we could use for a unit test?

Gagravarr commented on issue Gagravarr/VorbisJava#16
@Gagravarr

It's possible that some encoding tools might store that duration in the metadata, but it isn't standard. If not, you'll have to iterate over all th…

Gagravarr commented on pull request apache/tika#46
@Gagravarr

ODF, iWorks, OOXML, RDF and Atom are all xml-based (and some others too). However, all of those have their own packages, as while they're XML based…

Gagravarr commented on pull request apache/tika#46
@Gagravarr

Generally looks good One comment though - not sure that DIFContentHandler belongs in core? My hunch is that because it's specific to the DIF parser…

Gagravarr commented on pull request apache/tika#44
@Gagravarr

Any chance you could explain why this needs to be 50 not 40? (A unit test which shows the problem would be ideal!)

Gagravarr commented on pull request apache/tika#39
@Gagravarr

Looks good to me!

Gagravarr commented on pull request apache/tika#39
@Gagravarr

To help readability, I'd probably be inclined to have CompositeParser have an isExcluded method, which does both the excludeParsers.contains and as…

@Gagravarr
Gagravarr merged pull request Gagravarr/VorbisJava#13
@Gagravarr
Update links
1 commit with 2 additions and 2 deletions
@Gagravarr
Uses deprecated methods
@Gagravarr
Doesn't seem to work with OAuth 2?
Gagravarr commented on pull request apache/poi#18
@Gagravarr

Perfect, thanks! Committed in r1661908.

Gagravarr commented on pull request apache/poi#18
@Gagravarr

Purely style changes, but were it me: Might be good to put all the properties checks together Would probably be easier to read if you fetched the …

Gagravarr commented on pull request apache/poi#18
@Gagravarr

Is it worth also asserting that the text of the header is empty, do you think? Also, I've just noticed the naming of things like getHeaderArray(int)

Gagravarr commented on pull request apache/poi#18
@Gagravarr

Any chance you could update the unit test to also check that we correctly found the image in the header?

@Gagravarr
Gagravarr commented on pull request Gagravarr/VorbisJava#12
@Gagravarr

I ended up re-working quite a bit of this, in part to get more of the logic into things like OggAudioStatistcs. A lot of the overhead and bitrate s…

@Gagravarr
@Gagravarr
@Gagravarr
@Gagravarr
  • @Gagravarr 9608576
    Start to test overhead and OggAudioStatistics