From e192cd12f0ee1f5d9b4207fc3389a65f307171df Mon Sep 17 00:00:00 2001 From: nstarman Date: Fri, 19 Jan 2024 17:43:35 -0500 Subject: [PATCH] enforce strict abstract-concrete Signed-off-by: nstarman --- src/galax/dynamics/_core.py | 2 +- src/galax/dynamics/mockstream/_df/base.py | 2 +- src/galax/integrate/_base.py | 2 +- src/galax/potential/_potential/base.py | 2 +- src/galax/potential/_potential/core.py | 2 +- src/galax/potential/_potential/param/core.py | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/galax/dynamics/_core.py b/src/galax/dynamics/_core.py index 0f271b7f..8ef46637 100644 --- a/src/galax/dynamics/_core.py +++ b/src/galax/dynamics/_core.py @@ -18,7 +18,7 @@ from galax.potential._potential.base import AbstractPotentialBase -class AbstractPhaseSpacePositionBase(eqx.Module): # type: ignore[misc] +class AbstractPhaseSpacePositionBase(eqx.Module, strict=True): # type: ignore[call-arg, misc] """Abstract Base Class of Phase-Space Positions. Todo: diff --git a/src/galax/dynamics/mockstream/_df/base.py b/src/galax/dynamics/mockstream/_df/base.py index a4580ecb..34bbdc48 100644 --- a/src/galax/dynamics/mockstream/_df/base.py +++ b/src/galax/dynamics/mockstream/_df/base.py @@ -20,7 +20,7 @@ Carry: TypeAlias = tuple[IntLike, Vec3, Vec3, Vec3, Vec3] -class AbstractStreamDF(eqx.Module): # type: ignore[misc] +class AbstractStreamDF(eqx.Module, strict=True): # type: ignore[call-arg, misc] lead: bool = eqx.field(default=True, static=True) trail: bool = eqx.field(default=True, static=True) diff --git a/src/galax/integrate/_base.py b/src/galax/integrate/_base.py index 0315d256..3c9c402f 100644 --- a/src/galax/integrate/_base.py +++ b/src/galax/integrate/_base.py @@ -31,7 +31,7 @@ def __call__(self, t: FloatScalar, qp: Vec6, args: tuple[Any, ...]) -> Vec6: ... -class AbstractIntegrator(eqx.Module): # type: ignore[misc] +class AbstractIntegrator(eqx.Module, strict=True): # type: ignore[call-arg, misc] """Integrator Class. The integrators are classes that are used to integrate the equations of diff --git a/src/galax/potential/_potential/base.py b/src/galax/potential/_potential/base.py index c1af27a1..1d499a71 100644 --- a/src/galax/potential/_potential/base.py +++ b/src/galax/potential/_potential/base.py @@ -37,7 +37,7 @@ default_integrator = DiffraxIntegrator() -class AbstractPotentialBase(eqx.Module, metaclass=ModuleMeta): # type: ignore[misc] +class AbstractPotentialBase(eqx.Module, metaclass=ModuleMeta, strict=True): # type: ignore[misc] """Potential Class.""" units: eqx.AbstractVar[UnitSystem] diff --git a/src/galax/potential/_potential/core.py b/src/galax/potential/_potential/core.py index 62e0ec40..8cb02503 100644 --- a/src/galax/potential/_potential/core.py +++ b/src/galax/potential/_potential/core.py @@ -13,7 +13,7 @@ from .utils import converter_to_usys -class AbstractPotential(AbstractPotentialBase): +class AbstractPotential(AbstractPotentialBase, strict=True): _: KW_ONLY units: UnitSystem = eqx.field(converter=converter_to_usys, static=True) _G: float = eqx.field(init=False, static=True, repr=False, converter=float) diff --git a/src/galax/potential/_potential/param/core.py b/src/galax/potential/_potential/param/core.py index c8430592..487a37e0 100644 --- a/src/galax/potential/_potential/param/core.py +++ b/src/galax/potential/_potential/param/core.py @@ -20,7 +20,7 @@ from galax.utils.dataclasses import converter_float_array -class AbstractParameter(eqx.Module): # type: ignore[misc] +class AbstractParameter(eqx.Module, strict=True): # type: ignore[call-arg, misc] """Abstract Base Class for Parameters on a Potential. Parameters are time-dependent quantities that are used to define a