New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Python3 installation via "pip3 install pwntools" #1093

Merged
merged 1 commit into from Jan 4, 2018

Conversation

Projects
None yet
2 participants
@zachriggle
Contributor

zachriggle commented Jan 4, 2018

Pwntools does not work on Python3, so that it installs successfully is misleading.

More information on 'python_requires' can be found here:

https://packaging.python.org/tutorials/distributing-packages/#python-requires

Specifically, it requires pip 9.0 or better -- but this is the 'official' way to do this.

Fixes #1092

Prevent Python3 installation via "pip3 install pwntools"
Pwntools does not work on Python3, so that it installs successfully is misleading.

More information on 'python_requires' can be found here:

    https://packaging.python.org/tutorials/distributing-packages/#python-requires

Specifically, it requires pip 9.0 or better -- but this is the 'official' way to do this.

Fixes #1092

@zachriggle zachriggle added the releases label Jan 4, 2018

@zachriggle zachriggle added this to the Someday milestone Jan 4, 2018

@zachriggle zachriggle requested a review from Idolf Jan 4, 2018

@Idolf

Idolf approved these changes Jan 4, 2018

@zachriggle zachriggle merged commit 7860eec into Gallopsled:dev Jan 4, 2018

3 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.007%) to 57.827%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment