New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corefile: expose address to argc #1200

Merged
merged 1 commit into from Oct 9, 2018

Conversation

Projects
None yet
2 participants
@Mic92
Contributor

Mic92 commented Oct 1, 2018

This is useful to reconstruct register states of main even
when the stack is smashed.
As the value is already calculated this does not add much code.

I was lazy and did not run the tests yet, but the code should be covered by the existing doctest already and a quick manual test worked as expected, so please wait for travis to finish.

@Mic92

This comment has been minimized.

Show comment
Hide comment
@Mic92

Mic92 Oct 1, 2018

Contributor

Looks like elftools break compatibility: https://travis-ci.com/Mic92/pwntools/builds/86468434#L2101

Contributor

Mic92 commented Oct 1, 2018

Looks like elftools break compatibility: https://travis-ci.com/Mic92/pwntools/builds/86468434#L2101

@Mic92

This comment has been minimized.

Show comment
Hide comment
@Mic92

Mic92 Oct 1, 2018

Contributor

Ah this was already fixed on master.

Contributor

Mic92 commented Oct 1, 2018

Ah this was already fixed on master.

@zachriggle

This comment has been minimized.

Show comment
Hide comment
@zachriggle

zachriggle Oct 1, 2018

Contributor

Would you mind extending this to argv and envp as well?

Thanks!

Contributor

zachriggle commented Oct 1, 2018

Would you mind extending this to argv and envp as well?

Thanks!

@Mic92

This comment has been minimized.

Show comment
Hide comment
@Mic92

Mic92 Oct 1, 2018

Contributor

sure.

Contributor

Mic92 commented Oct 1, 2018

sure.

corefile: expose address to argc/argv/envp
This is useful to reconstruct register state of main even
when the stack is smashed.
As the value is already calculated this does not add much code.
@Mic92

This comment has been minimized.

Show comment
Hide comment
@Mic92

Mic92 Oct 3, 2018

Contributor

Apart from that it looks ready to me.

Contributor

Mic92 commented Oct 3, 2018

Apart from that it looks ready to me.

@Mic92

This comment has been minimized.

Show comment
Hide comment
@Mic92

Mic92 Oct 9, 2018

Contributor

Probably my last pull request for quite a while Mic92@2b493c6

Contributor

Mic92 commented Oct 9, 2018

Probably my last pull request for quite a while Mic92@2b493c6

@zachriggle zachriggle merged commit 5359ea7 into Gallopsled:dev Oct 9, 2018

3 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.02%) to 58.628%
Details

@Mic92 Mic92 deleted the Mic92:argcp branch Oct 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment