New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker: Kill 14 layers in pwntools base images #1202

Merged
merged 2 commits into from Oct 4, 2018

Conversation

Projects
None yet
2 participants
@kpcyrd
Contributor

kpcyrd commented Oct 3, 2018

We noticed that pwntools/pwntools has an excessive amount of layers, this change squashes 14 of them into a single layer.

@zachriggle

This comment has been minimized.

Show comment
Hide comment
@zachriggle

zachriggle Oct 3, 2018

Contributor

AFAICT, this require re-running all commands every time anything changes, and re-downloading the entire image any time there's a new Pwntools release (vs just the last layer)

Contributor

zachriggle commented Oct 3, 2018

AFAICT, this require re-running all commands every time anything changes, and re-downloading the entire image any time there's a new Pwntools release (vs just the last layer)

@zachriggle

This comment has been minimized.

Show comment
Hide comment
@zachriggle

zachriggle Oct 3, 2018

Contributor

Ah, I see these are the base images, not dev / beta / stable

Contributor

zachriggle commented Oct 3, 2018

Ah, I see these are the base images, not dev / beta / stable

Show resolved Hide resolved extra/docker/kali/Dockerfile

@zachriggle zachriggle merged commit c3c06a3 into Gallopsled:dev Oct 4, 2018

3 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.02%) to 58.588%
Details

@kpcyrd kpcyrd deleted the kpcyrd:docker branch Oct 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment