New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): avoid RecursionError due to weird monkey patching #1225

Merged
merged 1 commit into from Nov 13, 2018

Conversation

Projects
None yet
2 participants
@bennofs
Contributor

bennofs commented Nov 13, 2018

This fixes a RecursionError I hit during sphinx-build2 -v -b doctest docs/source docs/build/doctest docs/source/fmtstr.rst

fix(tests): avoid RecursionError due to weird monkey patching
Instead of patching the whole class which produced a RecursionError we now only
patch a single function which should be less invasive.

An example of how this bug manifests can be found at https://gist.github.com/bennofs/6252b45bd026d7e95dbacf7615159ed5.

@zachriggle zachriggle merged commit 6a094ec into Gallopsled:dev Nov 13, 2018

2 of 3 checks passed

Codacy/PR Quality Review Hang in there, Codacy is reviewing your Pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.02%) to 58.594%
Details

@bennofs bennofs deleted the bennofs:fix-sphinx-doctest branch Nov 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment