Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1279 #1304

Merged
merged 2 commits into from May 8, 2019

Conversation

@ZetaTwo
Copy link
Contributor

commented May 7, 2019

Messed up basing, re-opening instead of #1301
Sorry about that.

ZetaTwo added 2 commits May 6, 2019
@ZetaTwo

This comment has been minimized.

Copy link
Contributor Author

commented May 7, 2019

I'm not sure why the all assignment is split across two lines, we could probably condense them. Are pickle and StringIO still available if you remove the top line?

Yes, they are. Added change to remove the redundant part. Still think it feels a bit odd to absure globals like that but it does work.

@Arusekk Arusekk merged commit 64f97df into Gallopsled:dev3 May 8, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.004%) to 58.342%
Details
@ZetaTwo ZetaTwo deleted the ZetaTwo:issue-1279 branch May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.