Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev3] Minor changes for python3 support #1310

Merged
merged 6 commits into from Jun 22, 2019

Conversation

@mcd1992
Copy link
Contributor

commented May 17, 2019

Remove downgrade requirement for sortedcontainers and intervaltree.
Change the call to intervaltree's search in elf/elf.py to the new overlap function
Spit out usage text if pwn commandline bin is called without arguments.

With these changes I was able to get it working fine on arch without requiring any downgraded packages or other weird tricks. Not entirely sure if this is python 2 incompatible. From what I can see python2 has errno in its own library, the latest py2 intervaltree has search split into overlap/envelop so I'd imagine its fine.

mcd1992 added 3 commits May 16, 2019
Also make the pwn command show usage if no arguments supplied
The errno library moved out of os and into its own library
Copy link
Collaborator

left a comment

Nice done! Thank you for doing this, I thought that it would be harder. A minor change is required for the automated requirement systems to update libraries (e.g. Travis CI)

setup.py Outdated Show resolved Hide resolved
Copy link
Collaborator

left a comment

Please merge the suggestion first

@zachriggle

This comment has been minimized.

Copy link
Contributor

commented May 22, 2019

Looks like this breaks Python2. Separately, @Arusekk, we should probably change the CI to use Python3.7

@Arusekk

This comment has been minimized.

Copy link
Collaborator

commented May 22, 2019

Well, as for py2, pip plans to drop its support as soon as it gets EOL'd. But in this case it seems to be a fault of CI

@Arusekk

This comment has been minimized.

Copy link
Collaborator

commented Jun 11, 2019

For reference: pypa/pip#6275

We can install separately requirements before installing the project, or not use --editable, or build egg info separately

@Arusekk Arusekk merged commit 6f127e7 into Gallopsled:dev3 Jun 22, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.05%) to 58.333%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.