Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DynELF: Python 3 fixes for string/bytes comparisons #1426

Merged
merged 1 commit into from Feb 8, 2020

Conversation

@kazkansouh
Copy link
Contributor

kazkansouh commented Feb 8, 2020

Couple minor fixes for using DynELF with Python3 due to string/byte comparisons failing. Importantly this fixes an issue where DynELF's lookup function to find a symbol remotely.

There are possibly other issues along the same vein, as I did not use all features of the module.

Regarding test coverage, the module DynELF does not have any coverage (and I could not see a simple way of adding any as it would need a non-trivial leak function mocked) so I think its ok to leave testing is out of scope of this PR.

@Arusekk Arusekk merged commit ed3c30a into Gallopsled:dev Feb 8, 2020
1 of 2 checks passed
1 of 2 checks passed
coverage/coveralls Coverage decreased (-3.7%) to 61.965%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.