New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements to documentation for hacking HaLVM #122

Merged
merged 1 commit into from Jul 23, 2017

Conversation

Projects
None yet
3 participants
@mspaulding06
Contributor

mspaulding06 commented Jul 21, 2017

Just made a few very small improvements to the documentation. For instance, adding information on Fedora 26 (which is able to compile HaLVM) and updating commands and package information to make the build process a little smoother.

@izgzhen

This comment has been minimized.

Show comment
Hide comment
@izgzhen

izgzhen Jul 21, 2017

Contributor

Looks good overall. But I would suggest to make sure that the changed portion still applies to older versions, since it is said so. Or else, provide lines like this:

$ ifconfig # if Fedora 22, 23, 24

$ ip a # if Fedora 25, 26

What do you think?

Contributor

izgzhen commented Jul 21, 2017

Looks good overall. But I would suggest to make sure that the changed portion still applies to older versions, since it is said so. Or else, provide lines like this:

$ ifconfig # if Fedora 22, 23, 24

$ ip a # if Fedora 25, 26

What do you think?

@acw

This comment has been minimized.

Show comment
Hide comment
@acw

acw Jul 22, 2017

Member

w00t! Thanks!

Member

acw commented Jul 22, 2017

w00t! Thanks!

@acw acw closed this Jul 22, 2017

@mspaulding06

This comment has been minimized.

Show comment
Hide comment
@mspaulding06

mspaulding06 Jul 23, 2017

Contributor

@izgzhen I think that just including ip a should be fine if you are okay with that. The iproute package is included in Fedora back to release 22 and should be used where possible since ifconfig is deprecated.

Contributor

mspaulding06 commented Jul 23, 2017

@izgzhen I think that just including ip a should be fine if you are okay with that. The iproute package is included in Fedora back to release 22 and should be used where possible since ifconfig is deprecated.

@mspaulding06

This comment has been minimized.

Show comment
Hide comment
@mspaulding06

mspaulding06 Jul 23, 2017

Contributor

@acw Did you intend to close the PR without merging?

Contributor

mspaulding06 commented Jul 23, 2017

@acw Did you intend to close the PR without merging?

@acw

This comment has been minimized.

Show comment
Hide comment
@acw

acw Jul 23, 2017

Member

Ah-hah! You solved my brain teaser! Congrats!

Member

acw commented Jul 23, 2017

Ah-hah! You solved my brain teaser! Congrats!

@acw acw reopened this Jul 23, 2017

@acw acw merged commit ba2a398 into GaloisInc:master Jul 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment