New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wrong Behavior] Details will fail if IP is unset on multiple IPs systems #1385

Closed
UltimateByte opened this Issue Mar 28, 2017 · 7 comments

Comments

2 participants
@UltimateByte
Collaborator

UltimateByte commented Mar 28, 2017

The good point is that it provides the location in which to change the IP, but it shouldn't fail right away.

qlserver@rov:~$ ./qlserver dt
[ FAIL ] Details ql-server: Check IP: Multiple active network interfaces found.
Information! Specify the IP you want to use within the server config file ql-server.cfg.
/home/qlserver/serverfiles/baseq3/ql-server.cfg
Set set net_ip to one of the following:
xx.xx.xx.xx
xx.xx.xx.xx
xx.xx.xx.xx
https://gameservermanagers.com/network-interfaces
@dgibbs64

This comment has been minimized.

Member

dgibbs64 commented May 15, 2017

the IP needs to be set in order for correct details to be output. Otherwise details will not output the correct ip address. Its annoying for developers to keep having to enter the IP but is required for admins.

@UltimateByte

This comment has been minimized.

Collaborator

UltimateByte commented May 16, 2017

Well, it could show "NOT SET" rather than fail so that we can diagnose stuff quickly and get details even with a brand new script.

@dgibbs64

This comment has been minimized.

Member

dgibbs64 commented Jul 21, 2018

Happy for you to make this change unless it causes any unforeseen issues. Maybe have a warning message but it doesn't fail?

@UltimateByte

This comment has been minimized.

Collaborator

UltimateByte commented Jul 21, 2018

Achieved the desired behavior. PRing

@UltimateByte

This comment has been minimized.

Collaborator

UltimateByte commented Jul 21, 2018

How do we increase the milestone bar now? Status label? Merging and closing the issue?

@dgibbs64

This comment has been minimized.

Member

dgibbs64 commented Jul 21, 2018

Closing issues

@UltimateByte UltimateByte reopened this Jul 31, 2018

@UltimateByte

This comment has been minimized.

Collaborator

UltimateByte commented Jul 31, 2018

This is not solved for Eco.
After adding an IP to the config file, details still fails and other commands as well until "ip=" is set in LinuxGSM config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment