Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teamspeak3 server installation with MariaDB fixed. #2261

Merged
merged 20 commits into from Apr 7, 2019

Conversation

Projects
None yet
3 participants
@Vis25
Copy link
Contributor

commented Apr 6, 2019

Teamspeak3 server installation with MariaDB fixed.

  1. Installation script install_ts3db.sh will try to copy the required libts3db_mariadb.so from ${serverfiles}/redist/ and place it in ${serverfiles}, so that user does not have to do that by hand, and redo the installation.
  2. Typo at line 35 removed from - install_ts3db.sh echo "Updating config." was written in to the database connection configuration file ( ts3db_mariadb.ini ) ( should be outputted to the terminal. )
  3. Allows user to input database socket path in installation process.
    ( socket path will be written to the ts3db_mariadb.ini just like all other database connection details. )
    ( before just empty string was outputted. echo "socket=" )

Changes have been made to the master branch, sorry about that.
I found out that changes should be done to the develop branch while writing this pull request, so there is issue just comment and let me know, so i will re-do the changes to the develop branch.

Fixes #2260

Type of change

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • New Server (new server added)
  • Refactor (restructures existing code)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • This pull request links to an issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard to understand areas
  • I have made corresponding changes to the documentation if required
  • This pull request uses the develop branch as its base
  • I have squashed commits

Vis25 added some commits Apr 6, 2019

Fixes typo that writed unnecessary extra line to the ts3db_mariadb.in…
…i, also allows user to input path to mariadb socket, that will be writen to the ts3db_mariadb.ini.
If libmariadb.so.2 is not found in serverfiles/ try to move the file …
…from serverfiles/redist/ to the serverfiles/ - User friendly improvement.
@Vis25

This comment has been minimized.

Copy link
Contributor Author

commented Apr 6, 2019

Hey,

I I apologize if i have not followed you ways to commit code to the project, i tried my best to read your documentation, and follow the guide lines, but i have probably made mistakes.

So let me know about the issues so hopefully we can work my idea to the project.

This is first time trying to contribute to GitHub project.

Vis25 and others added some commits Apr 6, 2019

@GameServerManagers GameServerManagers deleted a comment from codacy-bot Apr 6, 2019

@dgibbs64 dgibbs64 added the type: bug label Apr 6, 2019

@GameServerManagers GameServerManagers deleted a comment from codacy-bot Apr 6, 2019

@dgibbs64

This comment has been minimized.

Copy link
Member

commented Apr 6, 2019

I'm doing a little refactor while I am reviewing stuff. Very happy with your changes :)

dgibbs64 added some commits Apr 6, 2019

@dgibbs64

This comment has been minimized.

Copy link
Member

commented Apr 7, 2019

Its ready to merge. Just haven't had a chance to sit down with this today. But it will be going in to the develop branch ready for next release. Thanks again for the really detailed issue and pr. Your welcome to contribute any time!

@Vis25

This comment has been minimized.

Copy link
Contributor Author

commented Apr 7, 2019

Hi,

I am more than happy to solve problem that effected my on experince with lgsm, and it's always great to make someones else life easyer.

Maybe i will get inspired by lgsm, and start contributing more, there is great chance for that because i love Bash projects 😅

This was also great first time experince with GitHub project, and happy to get involved with great tool that i have used for very long time by my self.

One question regarding the issue that i greated..
Do i close the issue in some point, or do you close the issue, or is the issue automaticaly solved when this pl goes true ? ( Dont want to leave solved issues open )

Best regards,
visdmin

@dgibbs64

This comment has been minimized.

Copy link
Member

commented Apr 7, 2019

I close the issues when I do a release. 👍

@dgibbs64

This comment has been minimized.

Copy link
Member

commented Apr 7, 2019

can you provide your github email. I am working on improved commit messages and need an email to add your info to contributors. This allows me to squash commits into a nice tidy message

Co-authored-by: name <name@example.com>

https://help.github.com/en/articles/creating-a-commit-with-multiple-authors

@GameServerManagers GameServerManagers deleted a comment from codacy-bot Apr 7, 2019

@dgibbs64

This comment has been minimized.

Copy link
Member

commented Apr 7, 2019

Changelog ready. @Vis25 please provide github email details then I can merge.

Co-authored-by: name name@example.com

  • fix(ts3server): can now add socket info to mariadb.ini
  • feat(ts3server): copy libmariadb.so.2 if not found in serverfiles
  • feat(install): EULA agreement now handled by install_eula.sh

@dgibbs64 dgibbs64 removed the status: triage label Apr 7, 2019

@dgibbs64 dgibbs64 added this to the next release milestone Apr 7, 2019

@Vis25

This comment has been minimized.

Copy link
Contributor Author

commented Apr 7, 2019

Hi,

I tried to add my email as public to thw github. Let me know if email is not visible for some reason.

@dgibbs64

This comment has been minimized.

Copy link
Member

commented Apr 7, 2019

Yup I can see it thanks

@dgibbs64 dgibbs64 merged commit 87b8ed4 into GameServerManagers:develop Apr 7, 2019

1 of 3 checks passed

Travis CI - Pull Request Build Errored
Details
Codacy/PR Quality Review Hang in there, Codacy is reviewing your Pull request.
Details
WIP Ready for review
Details

@conventional-release-bot conventional-release-bot bot referenced this pull request Apr 8, 2019

Merged

Feature/2270 ts3server #2273

6 of 12 tasks complete

@conventional-release-bot conventional-release-bot bot referenced this pull request Apr 22, 2019

Merged

Release/190422 #2301

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.