Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SVG support to FastDL #2298

Merged
merged 2 commits into from Apr 22, 2019

Conversation

Projects
None yet
2 participants
@borzaka
Copy link
Contributor

commented Apr 15, 2019

Description

CS:GO with Panorama now supports SVG custom logos, which are displayed in more places than a PNG logo.

Bonus:
Extend materials with .png support.

Fixes #2297

Edit: unfortunately it's not working for logos out-of-the-box, because the FastDL directory must be the same as in the CS:GO directory structure, so you have to manually create the folders and copy your logo files there.

Type of change

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • New Server (new server added)
  • Refactor (restructures existing code)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • This pull request links to an issue
  • This pull request uses the develop branch as its base
  • I have performed a self-review of my own code
  • I have squashed commits
  • I have commented my code, particularly in hard to understand areas
  • I have made corresponding changes to the documentation if required

borzaka added some commits Apr 15, 2019

Add SVG support to FastDL
CS:GO with Panorama now supports SVG custom logos, which are displayed in more places than a PNG logo.
Fixes #2297
Add PNG és SVG to materials extentions array
Panorama now uses materials/panorama/images/tournaments/teams folder to look for custom team logos, which can be .png and .svg
@dgibbs64

This comment has been minimized.

Copy link
Member

commented Apr 22, 2019

@borzaka Please can you provide your github email address so I can do a squash merge. Thanks

Co-authored-by:

@dgibbs64 dgibbs64 merged commit 24f0900 into GameServerManagers:develop Apr 22, 2019

3 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details

@borzaka borzaka deleted the borzaka:patch-1 branch Apr 22, 2019

@dgibbs64 dgibbs64 added this to the next release milestone Apr 22, 2019

@conventional-release-bot conventional-release-bot bot referenced this pull request Apr 22, 2019

Merged

Release/190422 #2301

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.