Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(alerts): add displayip variable #2310

Merged
merged 11 commits into from Jun 11, 2019

Conversation

Projects
None yet
2 participants
@dgibbs64
Copy link
Member

commented Apr 26, 2019

Description

Add the displayip variable to overwrite the default IP that is shown in alerts

Fixes #2192

Type of change

  • Bug fix (change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, etc).
  • This change requires a documentation update.

Checklist

  • This code follows the style guidelines of this project.
  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • I have provided Co-author details below.
  • I have performed a self-review of my own code.
  • I have squashed commits.
  • I have commented my code, particularly in hard to understand areas.
  • I have made corresponding changes to the documentation if required.

Provide Github Email

Fill out below info or tick box below:

Co-authored-by: John Doe <name@example.com>
  • I do not wish to provide an email. I am aware this will hide me as the author of this commit.

All pull requests will now be squashed to create a tidy commit history and simplify changelog creation. You can provide either your own email or a GitHub-provided no-reply email.

When a PR is squashed the author becomes the person who squashed the PR. This removes you as the author of your own PR.
The only workaround for this is to add your details as a co-author. More info about co-authors can be found here.

@dgibbs64 dgibbs64 changed the title added displayip var [WIP] added displayip var Apr 26, 2019

@dgibbs64 dgibbs64 changed the title [WIP] added displayip var [WIP] feat(alerts): add displayip variable Apr 26, 2019

@dgibbs64 dgibbs64 changed the title [WIP] feat(alerts): add displayip variable feat(alerts): add displayip variable Apr 28, 2019

@h3o66
Copy link
Contributor

left a comment

I think here are more changes in this commit then needed.

Example:
Changes for CentOS 8, Terraria, query monitoring udp and Travis tests

@dgibbs64 dgibbs64 changed the title feat(alerts): add displayip variable [WIP] feat(alerts): add displayip variable Jun 10, 2019

dgibbs64 added some commits Jun 11, 2019

if

@GameServerManagers GameServerManagers deleted a comment from codacy-bot Jun 11, 2019

dgibbs64 added some commits Jun 11, 2019

@dgibbs64 dgibbs64 changed the title [WIP] feat(alerts): add displayip variable feat(alerts): add displayip variable Jun 11, 2019

@GameServerManagers GameServerManagers deleted a comment from codacy-bot Jun 11, 2019

@dgibbs64 dgibbs64 merged commit 5901f19 into develop Jun 11, 2019

2 of 5 checks passed

Travis CI - Pull Request Build Errored
Details
Travis CI - Branch Build Failed
Details
prosebot No relevant files
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
WIP Ready for review
Details

@delete-merged-branch delete-merged-branch bot deleted the feature/displayip branch Jun 11, 2019

This was referenced Jun 16, 2019

@dgibbs64 dgibbs64 added this to the v19.7.0 milestone Jun 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.