Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Teeworlds config location #2313

Merged
merged 3 commits into from Apr 28, 2019

Conversation

Projects
None yet
2 participants
@Frisasky
Copy link
Contributor

commented Apr 27, 2019

Description

Teeworlds now only allow relative path for config file location, absolute path are not allowed. and config files must placed in same directory as game server binaries.

This is the only workaround i found after various experiments, existing installation must move config files from /serverfiles directory to /serverfiles/tw (which should affect very few, if any existing installations, as it would be discovered earlier when existing servers updates)

Fixes #2311

Type of change

  • Bug fix (change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, etc).
  • This change requires a documentation update.

Checklist

  • This code follows the style guidelines of this project.
  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • I have provided Co-author details below.
  • I have performed a self-review of my own code.
  • I have squashed commits.
  • I have commented my code, particularly in hard to understand areas.
  • I have made corresponding changes to the documentation if required.

Provide Github Email

Fill out below info or tick box below:

Co-authored-by: Frisa <digimoncn@gmail.com>
  • I do not wish to provide an email. I am aware this will hide me as the author of this commit.

All pull requests will now be squashed to create a tidy commit history and simplify changelog creation. You can provide either your own email or a GitHub-provided no-reply email.

When a PR is squashed the author becomes the person who squashed the PR. This removes you as the author of your own PR.
The only workaround for this is to add your details as a co-author. More info about co-authors can be found here.

Frisasky added some commits Apr 27, 2019

@Frisasky Frisasky changed the title Fix Teeworlds config location problem Fix Teeworlds config location Apr 27, 2019

@dgibbs64 dgibbs64 merged commit a7dc7fd into GameServerManagers:develop Apr 28, 2019

2 of 3 checks passed

Travis CI - Pull Request Build Errored
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
WIP Ready for review
Details
@dgibbs64

This comment has been minimized.

Copy link
Member

commented Apr 28, 2019

@all-contributors please add Frisasky for code contributions

@allcontributors

This comment has been minimized.

Copy link
Contributor

commented Apr 28, 2019

@dgibbs64

This project's configuration file has malformed JSON: .all-contributorsrc. Error:: Unexpected string in JSON at position 1752

@dgibbs64

This comment has been minimized.

Copy link
Member

commented Apr 28, 2019

@all-contributors please add Frisasky for code contributions

@allcontributors

This comment has been minimized.

Copy link
Contributor

commented Apr 28, 2019

@dgibbs64

I've put up a pull request to add @Frisasky! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.