Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary FreeForAll info, add map hint to Danger Zone, indent mod #2318

Merged
merged 1 commit into from Apr 28, 2019

Conversation

Projects
None yet
2 participants
@borzaka
Copy link
Contributor

commented Apr 28, 2019

Description

  • no need for FreeForAll text for Danger Zone
  • add map hint to Danger Zone (only map that can be used with this gamemode at the moment)
  • and some indentation fix

Type of change

  • Bug fix (change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, etc).
  • This change requires a documentation update.

Checklist

  • This code follows the style guidelines of this project.
  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • I have provided Co-author details below.
  • I have performed a self-review of my own code.
  • I have squashed commits.
  • I have commented my code, particularly in hard to understand areas.
  • I have made corresponding changes to the documentation if required.

Provide Github Email

Co-authored-by: Borzák Attila <1230402+borzaka@users.noreply.github.com>
  • I do not wish to provide an email. I am aware this will hide me as the author of this commit.

@dgibbs64 dgibbs64 merged commit b8f1c67 into GameServerManagers:develop Apr 28, 2019

3 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details

@dgibbs64 dgibbs64 added this to the new release milestone Apr 28, 2019

@dgibbs64

This comment has been minimized.

Copy link
Member

commented Apr 28, 2019

@allcontributors[bot] add @borzaka for code and bug contributions

@allcontributors

This comment has been minimized.

Copy link
Contributor

commented Apr 28, 2019

@dgibbs64

I've put up a pull request to add @borzaka! 🎉

@borzaka

This comment has been minimized.

Copy link
Contributor Author

commented Apr 29, 2019

Thx :)

@borzaka borzaka deleted the borzaka:patch-1 branch Apr 29, 2019

@conventional-release-bot conventional-release-bot bot referenced this pull request May 3, 2019

Merged

Release/190503 #2328

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.