Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(query-raw): add TCP/UDP query to game port #2341

Merged
merged 5 commits into from May 7, 2019

Conversation

Projects
None yet
2 participants
@dgibbs64
Copy link
Member

commented May 6, 2019

Description

TCP/UDP query for game ports has been added to query raw as a method of confirming if the game port is either TCP or UDP

Type of change

  • Bug fix (change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).
  • This change requires a documentation update.

Checklist

  • This code follows the style guidelines of this project.
  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • I have provided Co-author details below.
  • I have performed a self-review of my own code.
  • I have squashed commits.
  • I have commented my code, particularly in hard to understand areas.
  • I have made corresponding changes to the documentation if required.

Provide Github Email

Fill out below info or tick box below:

Co-authored-by: John Doe <name@example.com>
  • I do not wish to provide an email. I am aware this will hide me as the author of this commit.

All pull requests will now be squashed to create a tidy commit history and simplify changelog creation. You can provide either your own email or a GitHub-provided no-reply email.

When a PR is squashed the author becomes the person who squashed the PR. This removes you as the author of your own PR.
The only workaround for this is to add your details as a co-author. More info about co-authors can be found here.

dgibbs64 added some commits May 6, 2019

@codacy-bot

This comment has been minimized.

Copy link

commented May 7, 2019

Codacy Here is an overview of what got changed by this pull request:

Issues
======
- Added 2
           

See the complete overview on Codacy

@GameServerManagers GameServerManagers deleted a comment from codacy-bot May 7, 2019

@dgibbs64 dgibbs64 merged commit ab48c0b into develop May 7, 2019

1 of 4 checks passed

Travis CI - Pull Request Build Errored
Details
Travis CI - Branch Build Failed
Details
prosebot No relevant files
Details
WIP Ready for review
Details

@delete-merged-branch delete-merged-branch bot deleted the feature/query-raw-gameport branch May 7, 2019

@dgibbs64 dgibbs64 added this to the v19.6.0 milestone May 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.