Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(details): add steam master server setting #2385

Merged
merged 21 commits into from Jun 11, 2019

Conversation

Projects
None yet
3 participants
@dgibbs64
Copy link
Member

commented Jun 9, 2019

Description

This setting if true will check that server is listed on the steam master server list. All game servers that are known to work with setting are set to true by default.

The output of this setting can be seen in details.

Fixes #2388

Type of change

  • Bug fix (change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).
  • This change requires a documentation update.

Checklist

  • This code follows the style guidelines of this project.
  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • I have provided Co-author details below.
  • I have performed a self-review of my own code.
  • I have squashed commits.
  • I have commented my code, particularly in hard to understand areas.
  • I have made corresponding changes to the documentation if required.

Provide Github Email

Fill out below info or tick box below:

Co-authored-by: John Doe <name@example.com>
  • I do not wish to provide an email. I am aware this will hide me as the author of this commit.

All pull requests will now be squashed to create a tidy commit history and simplify changelog creation. You can provide either your own email or a GitHub-provided no-reply email.

When a PR is squashed the author becomes the person who squashed the PR. This removes you as the author of your own PR.
The only workaround for this is to add your details as a co-author. More info about co-authors can be found here.

dgibbs64 added some commits Jun 4, 2019

feat(config): add steam master setting
This setting if true will check that server is listed on the steam master server list. All game servers that are known to work with setting are set to true by default.

@dgibbs64 dgibbs64 changed the title feat(config): add steam master server setting [WIP] feat(config): add steam master server setting Jun 9, 2019

@xopez

This comment has been minimized.

Copy link

commented Jun 10, 2019

Maybe you shoud set glibc in ts3server to 2.17 since it's required with latest server.
Source: https://forum.teamspeak.com/threads/139966-Release-TeamSpeak-Server-3-8-0

Please note: we require glibc version 2.17 or later on Linux systems. This server will not show badges of other clients unless they are running client 3.3.0 or newer. That client should be available later this week, at least as a beta.

This server release should improve packet loss on systems under load, and fixes the server no longer accepting any connections with high query interface usage, among other improvements, please see the changelog for details.

You can grab the server from

@dgibbs64

This comment has been minimized.

Copy link
Member Author

commented Jun 10, 2019

@xopez can a new issue be raised for that please. Will need to update. The website.

@GameServerManagers GameServerManagers deleted a comment from codacy-bot Jun 10, 2019

@GameServerManagers GameServerManagers deleted a comment from codacy-bot Jun 10, 2019

dgibbs64 added some commits Jun 10, 2019

@GameServerManagers GameServerManagers deleted a comment from codacy-bot Jun 10, 2019

@GameServerManagers GameServerManagers deleted a comment from codacy-bot Jun 10, 2019

@GameServerManagers GameServerManagers deleted a comment from codacy-bot Jun 10, 2019

@dgibbs64 dgibbs64 changed the title [WIP] feat(config): add steam master server setting feat(config): add steam master server setting Jun 10, 2019

@codacy-bot

This comment has been minimized.

Copy link

commented Jun 11, 2019

Codacy Here is an overview of what got changed by this pull request:

Issues
======
- Added 1
           

See the complete overview on Codacy

@GameServerManagers GameServerManagers deleted a comment from codacy-bot Jun 11, 2019

@dgibbs64 dgibbs64 changed the title feat(config): add steam master server setting feat(details): add steam master server setting Jun 11, 2019

@dgibbs64 dgibbs64 merged commit 389cbe7 into develop Jun 11, 2019

1 of 5 checks passed

Travis CI - Pull Request Build Errored
Details
Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details
Travis CI - Branch Build Failed
Details
prosebot No relevant files
Details
WIP Ready for review
Details

@delete-merged-branch delete-merged-branch bot deleted the feature/master-server branch Jun 11, 2019

This was referenced Jun 16, 2019

@dgibbs64 dgibbs64 added this to the v19.7.0 milestone Jun 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.