Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(monitor): monitor queries will not begin immediately after start #2391

Merged
merged 23 commits into from Jun 16, 2019

Conversation

Projects
None yet
1 participant
@dgibbs64
Copy link
Member

commented Jun 15, 2019

Description

As a server admin, I would like a delay on the monitor querying the game server after starting as it takes time for the server to fully boot

Is your feature request related to a problem? Please describe.
It can sometimes take a few minutes for a server that has just started to boot and be ready to receive queries.

Describe the solution you'd like
Adding a lock file with the time and a variable querydelay=5 will cause the monitor to only check the binary is running and not query the server. After 5 mins the monitor will query as normal.

Fixes #2119

Type of change

  • Bug fix (change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).
  • This change requires a documentation update.

Checklist

  • This code follows the style guidelines of this project.
  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • I have provided Co-author details below.
  • I have performed a self-review of my own code.
  • I have squashed commits.
  • I have commented my code, particularly in hard to understand areas.
  • I have made corresponding changes to the documentation if required.

Provide Github Email

Fill out below info or tick box below:

Co-authored-by: John Doe <name@example.com>
  • I do not wish to provide an email. I am aware this will hide me as the author of this commit.

All pull requests will now be squashed to create a tidy commit history and simplify changelog creation. You can provide either your own email or a GitHub-provided no-reply email.

When a PR is squashed the author becomes the person who squashed the PR. This removes you as the author of your own PR.
The only workaround for this is to add your details as a co-author. More info about co-authors can be found here.

dgibbs64 added some commits Apr 9, 2019

@dgibbs64 dgibbs64 merged commit eb391b1 into develop Jun 16, 2019

4 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details

@delete-merged-branch delete-merged-branch bot deleted the feature/2119-lockfile branch Jun 16, 2019

This was referenced Jun 16, 2019

@dgibbs64 dgibbs64 added this to the v19.7.0 milestone Jun 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.