Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(newserver): Barotrauma #2400

Merged
merged 14 commits into from Jun 16, 2019

Conversation

Projects
None yet
2 participants
@dgibbs64
Copy link
Member

commented Jun 16, 2019

Description

PR for Barotrauma support

Fixes #2395

Note that:

  • There is a GLIBC error when starting, thinking the minimum required is UNKNOWN (while set to 2.17)
  • Engine is set to null, as unknown and most likely custom.
  • I based this off the master branch accidentally, let me know if I should rebase.
  • Barotrauma server requires you to login with your steam account, that owns the game.

Type of change

  • Bug fix (change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).
  • This change requires a documentation update.

Checklist

  • This code follows the style guidelines of this project.
  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • I have provided Co-author details below.
  • I have performed a self-review of my own code.
  • I have squashed commits.
  • I have commented my code, particularly in hard to understand areas.
  • I have made corresponding changes to the documentation if required.

Provide Github Email

Fill out below info or tick box below:

Co-authored-by: Yann Kraetzschmann <ypk@online.fr>
  • I do not wish to provide an email. I am aware this will hide me as the author of this commit.

All pull requests will now be squashed to create a tidy commit history and simplify changelog creation. You can provide either your own email or a GitHub-provided no-reply email.

When a PR is squashed the author becomes the person who squashed the PR. This removes you as the author of your own PR.
The only workaround for this is to add your details as a co-author. More info about co-authors can be found here.

YannKr and others added some commits Jun 16, 2019

@dgibbs64 dgibbs64 merged commit 1fabc01 into GameServerManagers:develop Jun 16, 2019

2 of 3 checks passed

Travis CI - Pull Request Build Errored
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
WIP Ready for review
Details

@dgibbs64 dgibbs64 added this to the v19.7.0 milestone Jun 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.