Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(backup): unify backupdir on all configs #2405

Merged
merged 17 commits into from Aug 27, 2019

Conversation

@h3o66
Copy link
Contributor

commented Jun 22, 2019

Description

Please include a summary of the change and which issues is fixed

Fixes #2398

Type of change

  • Bug fix (change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This code follows the style guidelines of this project.
  • I have provided Co-author details below.
  • I have performed a self-review of my own code.
  • I have checked that this code is commented where required.
  • I have provided a detailed enough description of this PR.
  • I have checked If documentation needs updating.

Provide Github Email

Fill out below info or tick box below:

Co-authored-by: Christian Birk <chris.h3o66@gmail.com>
@dgibbs64

This comment has been minimized.

Copy link
Member

commented Jun 23, 2019

The only issue I see is that the old backups will then be in the wrong directory. I think something needs to be done to migrate them to the new directory.

@h3o66

This comment has been minimized.

Copy link
Contributor Author

commented Jul 2, 2019

Added little migration function for this commit

@dgibbs64 dgibbs64 self-requested a review Jul 4, 2019

dgibbs64 added 6 commits Aug 24, 2019
/
bug
@dgibbs64

This comment has been minimized.

Copy link
Member

commented Aug 25, 2019

@h3o66 Need permission to this one as well please. In fact please could you check all outstanding PR's 👍

@h3o66

This comment has been minimized.

Copy link
Contributor Author

commented Aug 25, 2019

@h3o66 Need permission to this one as well please. In fact please could you check all outstanding PR's

is there already

dgibbs64 added 7 commits Aug 27, 2019
if
# Migrate Backups from old dir before refactor
fn_backup_migrate_olddir(){
# Check if old backup dir is there before the refactor and move the backups
if [ -d "" ]; then

This comment has been minimized.

Copy link
@dgibbs64

dgibbs64 Aug 27, 2019

Member

Missing the legacy directory

This comment has been minimized.

Copy link
@dgibbs64

dgibbs64 Aug 27, 2019

Member

Also, a message is required to advise users that the backup directory is being migrated.

I recommend something like
backup directory is being migrated too [new location]... PASS

This will give a pass or fail message.

@dgibbs64 dgibbs64 changed the title refactor(backup) unify backup dir on all configs refactor(backup): unify backupdir on all configs Aug 27, 2019

@dgibbs64 dgibbs64 merged commit 20473df into GameServerManagers:develop Aug 27, 2019

1 of 2 checks passed

Travis CI - Pull Request Build Errored
Details
WIP Ready for review
Details

@h3o66 h3o66 deleted the h3o66:refactor/backuppdir branch Aug 27, 2019

@dgibbs64 dgibbs64 added this to the v19.10.0 milestone Sep 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.