Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(newserver): SourceForts Classic #2430

Merged
merged 10 commits into from Jul 5, 2019

Conversation

Projects
None yet
3 participants
@Frisasky
Copy link
Contributor

commented Jul 2, 2019

Description

check discord message for downloadl url

Fixes #2209

Type of change

  • Bug fix (change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).
  • This change requires a documentation update.

Checklist

  • This code follows the style guidelines of this project.
  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • I have provided Co-author details below.
  • I have performed a self-review of my own code.
  • I have squashed commits.
  • I have commented my code, particularly in hard to understand areas.
  • I have made corresponding changes to the documentation if required.

Provide Github Email

Fill out below info or tick box below:

Co-authored-by: John Doe <name@example.com>
  • I do not wish to provide an email. I am aware this will hide me as the author of this commit.

All pull requests will now be squashed to create a tidy commit history and simplify changelog creation. You can provide either your own email or a GitHub-provided no-reply email.

When a PR is squashed the author becomes the person who squashed the PR. This removes you as the author of your own PR.
The only workaround for this is to add your details as a co-author. More info about co-authors can be found here.

Frisasky added some commits Jun 21, 2019

@GameServerManagers GameServerManagers deleted a comment from codacy-bot Jul 2, 2019

@Frisasky Frisasky requested a review from dgibbs64 Jul 2, 2019

@GameServerManagers GameServerManagers deleted a comment from codacy-bot Jul 2, 2019

migrated fix to on start
Moved so it can re-generate if accidentally deleted

@GameServerManagers GameServerManagers deleted a comment from codacy-bot Jul 5, 2019

@codacy-bot

This comment has been minimized.

Copy link

commented Jul 5, 2019

Codacy Here is an overview of what got changed by this pull request:

Issues
======
- Added 1
           

See the complete overview on Codacy

@dgibbs64 dgibbs64 merged commit eb17129 into GameServerManagers:develop Jul 5, 2019

1 of 3 checks passed

Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details
Travis CI - Pull Request Build Failed
Details
WIP Ready for review
Details

@dgibbs64 dgibbs64 added this to the v19.9.0 milestone Jul 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.