Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(newserver): Soldat #2445

Merged
merged 22 commits into from Aug 25, 2019
Merged

Conversation

h3o66
Copy link
Member

@h3o66 h3o66 commented Jul 16, 2019

Description

New Server Soldat

Fixes #2083

Type of change

  • Bug fix (change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This code follows the style guidelines of this project.
  • I have provided Co-author details below.
  • I have performed a self-review of my own code.
  • I have checked that this code is commented where required.
  • I have provided a detailed enough description of this PR.
  • I have checked If documentation needs updating.

Provide Github Email

Fill out below info or tick box below:

Co-authored-by: Christian Birk <chris.h3o66@gmail.com>
  • I do not wish to provide an email. I am aware this will hide me as the author of this commit.

All pull requests will now be squashed to create a tidy commit history and simplify changelog creation. You can provide either your own email or a GitHub-provided no-reply email.

When a PR is squashed the author becomes the person who squashed the PR. This removes you as the author of your own PR.
The only workaround for this is to add your details as a co-author. More info about co-authors can be found here.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

@h3o66 h3o66 added the type: game server request Request for a new server label Jul 16, 2019
@dgibbs64 dgibbs64 self-requested a review August 24, 2019 16:34
Copy link
Member

@dgibbs64 dgibbs64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All working apart form querying is not configured for gamedig or gsquery. Please, can this be sorted and then I can merge. If you get please let me know.

@dgibbs64
Copy link
Member

@h3o66 for some reason I can push to this PR seems to be a permissions issue. Odd as I can normally do this

@h3o66
Copy link
Member Author

h3o66 commented Aug 25, 2019

@h3o66 for some reason I can push to this PR seems to be a permissions issue. Odd as I can normally do this

the tick to allow this was missing, now allowed

@dgibbs64
Copy link
Member

Awesome thanks :)

@dgibbs64 dgibbs64 changed the title feat(newserver) Soldat feat(newserver): Soldat Aug 25, 2019
@dgibbs64 dgibbs64 merged commit bcd585b into GameServerManagers:develop Aug 25, 2019
@conventional-release-bot conventional-release-bot bot mentioned this pull request Aug 28, 2019
14 tasks
@dgibbs64 dgibbs64 added this to the v19.10.0 milestone Sep 17, 2019
@h3o66 h3o66 deleted the feature/soldat branch November 22, 2020 14:45
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants