Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(btserver): Barotrauma has a new server binary location #2477

Merged
merged 1 commit into from Aug 23, 2019

Conversation

@h3o66
Copy link
Contributor

commented Aug 16, 2019

Description

Fix server binary for Barotrauma

Fixes #2453

Type of change

  • Bug fix (change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This code follows the style guidelines of this project.
  • I have provided Co-author details below.
  • I have performed a self-review of my own code.
  • I have checked that this code is commented where required.
  • I have provided a detailed enough description of this PR.
  • I have checked If documentation needs updating.

Provide Github Email

Fill out below info or tick box below:

Co-authored-by: John Doe <chris.h3o66@gmail.com>
  • I do not wish to provide an email. I am aware this will hide me as the author of this commit.

All pull requests will now be squashed to create a tidy commit history and simplify changelog creation. You can provide either your own email or a GitHub-provided no-reply email.

When a PR is squashed the author becomes the person who squashed the PR. This removes you as the author of your own PR.
The only workaround for this is to add your details as a co-author. More info about co-authors can be found here.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

@h3o66 h3o66 added the type: bug label Aug 16, 2019

@h3o66 h3o66 force-pushed the h3o66:fix/2453-bt-binary branch from 7b3e441 to c8ac9c8 Aug 18, 2019

@h3o66 h3o66 force-pushed the h3o66:fix/2453-bt-binary branch from c8ac9c8 to 921a7a8 Aug 18, 2019

@dgibbs64 dgibbs64 self-requested a review Aug 23, 2019

@dgibbs64
Copy link
Member

left a comment

Mono needs to be added as a requirement if it is not already

@h3o66

This comment has been minimized.

Copy link
Contributor Author

commented Aug 23, 2019

This "exe" is actually a script.
so mono is not needed

@dgibbs64

This comment has been minimized.

Copy link
Member

commented Aug 23, 2019

Well that's confusing and weird.

@h3o66

This comment has been minimized.

Copy link
Contributor Author

commented Aug 23, 2019

image
Here the question what i asked on the discord of them

@dgibbs64 dgibbs64 changed the title fix(btserver): fix serverbinary fix(btserver): Barotrauma has a new server binary location Aug 23, 2019

@dgibbs64 dgibbs64 merged commit 44eb070 into GameServerManagers:develop Aug 23, 2019

3 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
@conventional-release-bot conventional-release-bot bot referenced this pull request Aug 28, 2019
0 of 14 tasks complete

@dgibbs64 dgibbs64 added this to the v19.10.0 milestone Sep 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.