Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(postdetails): add postdetails support for #2485

merged 4 commits into from Aug 28, 2019


Copy link

commented Aug 26, 2019


Added postdetails support for This was required for my setup because the Hastebin and Pastebin options were both breaking for me.

Fixes #2383

Type of change

  • Bug fix (change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).


PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This code follows the style guidelines of this project.
  • I have provided Co-author details below.
  • I have performed a self-review of my own code.
  • I have checked that this code is commented where required.
  • I have provided a detailed enough description of this PR.
  • I have checked If documentation needs updating.

Provide Github Email

Fill out below info or tick box below:

Co-authored-by: John Doe <>
  • I do not wish to provide an email. I am aware this will hide me as the author of this commit.

All pull requests will now be squashed to create a tidy commit history and simplify changelog creation. You can provide either your own email or a GitHub-provided no-reply email.

When a PR is squashed the author becomes the person who squashed the PR. This removes you as the author of your own PR.
The only workaround for this is to add your details as a co-author. More info about co-authors can be found here.


If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!


This comment has been minimized.

Copy link

commented Aug 27, 2019

please rebase to develop branch

@dgibbs64 dgibbs64 changed the base branch from master to develop Aug 27, 2019

@dgibbs64 dgibbs64 changed the title Added postdetails support for feat(postdetails): add postdetails support for Aug 27, 2019

@dgibbs64 dgibbs64 self-requested a review Aug 27, 2019

Copy link

left a comment

@ip2k please provide co-author details and raise an issue relating to this so I can merge. Thank you

@dgibbs64 dgibbs64 merged commit c3521ba into GameServerManagers:develop Aug 28, 2019

3 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Travis CI - Pull Request Build Passed
WIP Ready for review
@conventional-release-bot conventional-release-bot bot referenced this pull request Aug 28, 2019
0 of 14 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
3 participants
You can’t perform that action at this time.