Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(refactor): general refactor of if statements #2492

Merged
merged 6 commits into from Aug 30, 2019

Conversation

@dgibbs64
Copy link
Member

commented Aug 28, 2019

Description

Standardsiseing some if statements and minor code improvements from today recommendations

Fixes #[issue]

Type of change

  • Bug fix (change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This code follows the style guidelines of this project.
  • I have provided Co-author details below.
  • I have performed a self-review of my own code.
  • I have checked that this code is commented where required.
  • I have provided a detailed enough description of this PR.
  • I have checked If documentation needs updating.

Provide Github Email

Fill out below info or tick box below:

Co-authored-by: John Doe <name@example.com>
  • I do not wish to provide an email. I am aware this will hide me as the author of this commit.

All pull requests will now be squashed to create a tidy commit history and simplify changelog creation. You can provide either your own email or a GitHub-provided no-reply email.

When a PR is squashed the author becomes the person who squashed the PR. This removes you as the author of your own PR.
The only workaround for this is to add your details as a co-author. More info about co-authors can be found here.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

dgibbs64 added 6 commits Aug 27, 2019

@dgibbs64 dgibbs64 merged commit 1d41bc6 into develop Aug 30, 2019

1 of 6 checks passed

Travis CI - Branch Build Errored
Details
Travis CI - Pull Request Build Errored
Details
Alex Alex has some suggestions!
Details
SpellCheck SpellCheck has some suggestions!
Details
WriteGood WriteGood has some suggestions!
Details
WIP Ready for review
Details

@delete-merged-branch delete-merged-branch bot deleted the feature/if-refactor branch Aug 30, 2019

@codacy-bot

This comment has been minimized.

Copy link

commented Aug 30, 2019

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 18
           

See the complete overview on Codacy

@GameServerManagers GameServerManagers deleted a comment from codacy-bot Aug 30, 2019

@dgibbs64 dgibbs64 added this to the v19.10.0 milestone Sep 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.