Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(_default.cfg): standardise design and bug fixes various issues with _default.cfg files #2582

Merged
merged 51 commits into from Nov 10, 2019

Conversation

@dgibbs64
Copy link
Member

dgibbs64 commented Nov 10, 2019

Description

Various updates and bug fixes to _default.cfg files

Fixes #[issue]

Type of change

  • Bug fix (change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have checked that this code is commented where required.
  • I have provided a detailed enough description of this PR.
  • I have checked If documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

dgibbs64 added 30 commits May 6, 2019
…ates
dgibbs64 added 21 commits Nov 5, 2019
@dgibbs64 dgibbs64 changed the title fix(_default.cfg): update and bug various issues with _default.cfg files fix(_default.cfg): standardise design and bug fixes various issues with _default.cfg files Nov 10, 2019
@dgibbs64 dgibbs64 merged commit e271439 into develop Nov 10, 2019
3 of 5 checks passed
3 of 5 checks passed
Travis CI - Pull Request Build Errored
Details
Codacy/PR Quality Review Hang in there, Codacy is reviewing your Pull request.
Details
Semantic Pull Request ready to be squashed
Details
Travis CI - Branch Build Passed
Details
WIP Ready for review
Details
@delete-merged-branch delete-merged-branch bot deleted the feature/config-updates branch Nov 10, 2019
@conventional-release-bot conventional-release-bot bot mentioned this pull request Nov 22, 2019
8 of 12 tasks complete
@conventional-release-bot conventional-release-bot bot mentioned this pull request Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.