Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ts3server): ts3 version detection when server was started with 'logappend=1' #2584 #2585

Merged
merged 1 commit into from Nov 14, 2019

Conversation

@tam1m
Copy link
Contributor

tam1m commented Nov 12, 2019

Description

Fixes #2584

Type of change

  • Bug fix (change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have checked that this code is commented where required.
  • I have provided a detailed enough description of this PR.
  • I have checked If documentation needs updating.
@dgibbs64 dgibbs64 changed the title Fix ts3 version detection when server was started with 'logappend=1' #2584 fix(ts3server): td3 version detection when server was started with 'logappend=1' #2584 Nov 14, 2019
@dgibbs64 dgibbs64 changed the title fix(ts3server): td3 version detection when server was started with 'logappend=1' #2584 fix(ts3server): ts3 version detection when server was started with 'logappend=1' #2584 Nov 14, 2019
@dgibbs64 dgibbs64 merged commit ccab1fa into GameServerManagers:develop Nov 14, 2019
4 checks passed
4 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Semantic Pull Request ready to be squashed
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
@tam1m tam1m deleted the tam1m:ts3_update_fix branch Nov 15, 2019
@conventional-release-bot conventional-release-bot bot mentioned this pull request Nov 22, 2019
8 of 12 tasks complete
@dgibbs64 dgibbs64 added this to the v19.12.0 milestone Nov 27, 2019
@conventional-release-bot conventional-release-bot bot mentioned this pull request Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.