Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linuxgsm): depricate servicename variable #2594

Merged
merged 2 commits into from Nov 25, 2019

Conversation

@dgibbs64
Copy link
Member

dgibbs64 commented Nov 17, 2019

Description

As servicename is selfname it has now been completely replaced with selfname.

Fixes #[issue]

Type of change

  • Bug fix (change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have checked that this code is commented where required.
  • I have provided a detailed enough description of this PR.
  • I have checked If documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

dgibbs64 added 2 commits Nov 17, 2019
servicename has been now completely replaced with selfname
@dgibbs64

This comment has been minimized.

Copy link
Member Author

dgibbs64 commented Nov 18, 2019

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 5
- Added 5
           

See the complete overview on Codacy

@dgibbs64 dgibbs64 merged commit b4290a3 into develop Nov 25, 2019
4 of 6 checks passed
4 of 6 checks passed
Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details
Travis CI - Pull Request Build Failed
Details
prosebot No relevant files
Details
Semantic Pull Request ready to be squashed
Details
Travis CI - Branch Build Passed
Details
WIP Ready for review
Details
@delete-merged-branch delete-merged-branch bot deleted the feature/depricate-servicename branch Nov 25, 2019
@dgibbs64 dgibbs64 added this to the v19.12.0 milestone Nov 25, 2019
@conventional-release-bot conventional-release-bot bot mentioned this pull request Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.