Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/2597 https to http #2608

Merged
merged 1 commit into from Nov 22, 2019

Conversation

@dgibbs64
Copy link
Member

dgibbs64 commented Nov 22, 2019

Description

Game Servers that don't use SteamCMD will now use http instead of https. This is because older versions of curl on older distros are not keeping up with https related technologies and causing downloads to fail. As there is no sensitive data being transferred revering to http will ensure compatibility.

Fixes #2597

Type of change

  • Bug fix (change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have checked that this code is commented where required.
  • I have provided a detailed enough description of this PR.
  • I have checked If documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

@dgibbs64 dgibbs64 changed the base branch from master to develop Nov 22, 2019
@dgibbs64 dgibbs64 merged commit 56583d2 into develop Nov 22, 2019
4 of 5 checks passed
4 of 5 checks passed
Travis CI - Branch Build Failed
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Semantic Pull Request ready to be merged or rebased
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
@delete-merged-branch delete-merged-branch bot deleted the feature/2597-https-to-http branch Nov 22, 2019
@dgibbs64 dgibbs64 added this to the v19.12.0 milestone Nov 27, 2019
@conventional-release-bot conventional-release-bot bot mentioned this pull request Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.