Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eco): remove mono 6 as a dependency for eco (mono 5 still required) #2610

Merged
merged 1 commit into from Nov 23, 2019

Conversation

@dgibbs64
Copy link
Member

dgibbs64 commented Nov 23, 2019

Description

Removed mono as a dependency as LinuxGSM installs mono 6 using official mono repo.

eco does not work with mono 6 and only with mono 5

mono 5 is available on official distro repos.

eco will be removing the requirement for mono in release 0.9.0. So there is no point making significant code changes to facilitate this temporary issue.

simply following the dependency requirements on the website will allow eco to work.

Fixes #2549

Type of change

  • Bug fix (change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have checked that this code is commented where required.
  • I have provided a detailed enough description of this PR.
  • I have checked If documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

@dgibbs64 dgibbs64 merged commit 7280258 into develop Nov 23, 2019
4 of 5 checks passed
4 of 5 checks passed
Travis CI - Pull Request Build Errored
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Semantic Pull Request ready to be squashed
Details
Travis CI - Branch Build Passed
Details
WIP Ready for review
Details
@dgibbs64 dgibbs64 added this to the v19.12.0 milestone Nov 27, 2019
@conventional-release-bot conventional-release-bot bot mentioned this pull request Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.