Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(monitor): migrate monitor settings to _default.cfg #2611

Merged
merged 90 commits into from Nov 25, 2019

Conversation

@dgibbs64
Copy link
Member

dgibbs64 commented Nov 23, 2019

Description

As part of the task of making it easier to release game servers, monitor settings have been migrated over to _default.cfg

Fixes #[issue]

Type of change

  • Bug fix (change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have checked that this code is commented where required.
  • I have provided a detailed enough description of this PR.
  • I have checked If documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

dgibbs64 added 30 commits Nov 16, 2019
dgibbs64 added 20 commits Nov 23, 2019
bug
@dgibbs64 dgibbs64 changed the title [WIP] feat(monitor): migrade monitor settings to _default.cfg [WIP] feat(monitor): migrate monitor settings to _default.cfg Nov 25, 2019
@dgibbs64

This comment has been minimized.

Copy link
Member Author

dgibbs64 commented Nov 25, 2019

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 6
- Added 1
           

Complexity increasing per file
==============================
- lgsm/functions/query_gsquery.py  2
         

See the complete overview on Codacy

@dgibbs64 dgibbs64 changed the title [WIP] feat(monitor): migrate monitor settings to _default.cfg feat(monitor): migrate monitor settings to _default.cfg Nov 25, 2019
@dgibbs64 dgibbs64 merged commit 351cf40 into develop Nov 25, 2019
5 of 6 checks passed
5 of 6 checks passed
Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details
prosebot No relevant files
Details
Semantic Pull Request ready to be squashed
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
@delete-merged-branch delete-merged-branch bot deleted the feature/monitor-no-engine branch Nov 25, 2019
@dgibbs64 dgibbs64 added this to the v19.12.0 milestone Nov 25, 2019
@conventional-release-bot conventional-release-bot bot mentioned this pull request Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.