Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(refactor): double quote for branch name #2618

Merged
merged 5 commits into from Nov 27, 2019

Conversation

@Frisasky
Copy link
Contributor

Frisasky commented Nov 26, 2019

Description

refactor double quote so branch name wont be splitted

Type of change

  • Bug fix (change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have checked that this code is commented where required.
  • I have provided a detailed enough description of this PR.
  • I have checked If documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

Frisasky added 5 commits Nov 26, 2019
@Frisasky Frisasky changed the title feat(refactor): refactor double quote for branch name feat(refactor): double quote for branch name Nov 26, 2019
@dgibbs64 dgibbs64 merged commit fc72cae into GameServerManagers:develop Nov 27, 2019
4 checks passed
4 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Semantic Pull Request ready to be squashed
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
@conventional-release-bot conventional-release-bot bot mentioned this pull request Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.