Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fix): fix typo for rust wipe code #2634

Merged
merged 1 commit into from Dec 5, 2019

Conversation

@Frisasky
Copy link
Contributor

Frisasky commented Dec 2, 2019

Description

Fixes #2622

Type of change

  • Bug fix (change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request Subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have checked that this code is commented where required.
  • I have provided a detailed enough description of this PR.
  • I have checked If documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

@pull-assistant

This comment has been minimized.

Copy link

pull-assistant bot commented Dec 2, 2019

Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     Fix typo

Powered by Pull Assistant. Last update 6b93aab ... 6b93aab. Read the comment docs.

Copy link

asweiler left a comment

I tested this and it helps.

@dgibbs64 dgibbs64 merged commit d09b2ed into GameServerManagers:develop Dec 5, 2019
4 checks passed
4 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Semantic Pull Request ready to be squashed
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
frederic2ec added a commit to frederic2ec/LinuxGSM that referenced this pull request Feb 4, 2020
* fix(legacy): add service name to core_legacy.sh

* release v19.12.5

* fix(rustserver): fix typo for rust wipe code (GameServerManagers#2634)

* fix(doiserver): resolve server failing to restart without -norestart (GameServerManagers#2651)

* feat(post-details): change default post target from hastebin to termbin (GameServerManagers#2645)

Co-authored-by: Daniel Gibbs <me@danielgibbs.co.uk>
Co-authored-by: Frisasky <digimoncn@gmail.com>
@dgibbs64 dgibbs64 added this to the v20.1.0 milestone Mar 9, 2020
@conventional-release-bot conventional-release-bot bot mentioned this pull request Mar 13, 2020
0 of 13 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.